Thread (18 messages) 18 messages, 4 authors, 2025-11-10

Re: [PATCH V3 4/4] arm64: dts: qcom: sm8750-qrd: Add SDC2 node for sm8750 qrd board

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-10-27 14:34:54
Also in: linux-arm-msm, linux-mmc, lkml

On 26/10/2025 12:17, Sarthak Garg wrote:
quoted hunk ↗ jump to hunk
Enable SD Card host controller for sm8750 qrd board.

Signed-off-by: Sarthak Garg <redacted>
Reviewed-by: Abel Vesa <redacted>
---
 arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 13c7b9664c89..c2ab39744a0c 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -1031,6 +1031,29 @@ wcd_default: wcd-reset-n-active-state {
 		bias-disable;
 		output-low;
 	};
+
+	sdc2_card_det_n: sd-card-det-n-state {
+		pins = "gpio55";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-up;
+	};
+};
+
+&sdhc_2 {

That's random order. Please follow the order as expressed in DTS coding
style. This file already has broken Qualcomm style, but you do not have
to bring additional mistakes.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help