Thread (15 messages) 15 messages, 4 authors, 2025-10-23

Re: [PATCH 2/3] Input: add TWL603x power button

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2025-10-22 18:49:02
Also in: linux-input, linux-omap, lkml

On Wed, Oct 22, 2025 at 02:44:22PM +0200, Andreas Kemnade wrote:
On Tue, 21 Oct 2025 10:58:35 -0700
Dmitry Torokhov [off-list ref] wrote:
quoted
On Mon, Oct 20, 2025 at 02:31:59PM +0200, akemnade@kernel.org wrote:
quoted
From: Andreas Kemnade <andreas@kemnade.info>

Like the TWL4030, these PMICs also have a power button feature, so add
a driver for it.  
Could it be integrated into twl4030-pwrbutton.c? I think the differences
can be accounted for via a "chip" structure attached to a compatible...
So what is different:
- different register (but same bit)
- some custom irq stuff for 603x (so if (is_603x) needed)
Right, why do we need to unmask the interrupt by hand for 6030? I'd
expect this handled in the core, when we request the interrupt, not in
the button driver..in the core, when we request the interrupt, not in
the button driver...

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help