Thread (5 messages) 5 messages, 2 authors, 2025-10-01

Re: [PATCH v3 1/3] dt-bindings: gpio: rda: Make interrupts optional

From: Linus Walleij <hidden>
Date: 2025-10-01 11:41:30
Also in: linux-arm-kernel, linux-gpio, lkml

Hi Dang,

thanks for your patch!

On Sat, Sep 27, 2025 at 7:02 AM Dang Huynh [off-list ref] wrote:
The GPIO controller from the modem does not have an interrupt.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Dang Huynh <redacted>
If the GPIO controllers are so different, should they not have different
compatible strings?

Maybe add rda,8810pl-modem-gpio compatible for the modem
GPIO then?

 +++ b/Documentation/devicetree/bindings/gpio/gpio-rda.yaml
quoted hunk ↗ jump to hunk
@@ -41,9 +41,6 @@ required:
   - gpio-controller
   - "#gpio-cells"
   - ngpios
-  - interrupt-controller
-  - "#interrupt-cells"
-  - interrupts
Then this can be conditional using an if:-statement such that
it is only mandatory for rda,8810pl-gpio and not for
rda,8810pl-modem-gpio.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help