Re: [PATCH 03/17] drm/msm/adreno: Common-ize PIPE definitions

On Tue, Sep 30, 2025 at 12:05 AM Dmitry Baryshkov
[off-list ref] wrote:

On Tue, Sep 30, 2025 at 11:18:08AM +0530, Akhil P Oommen wrote:

quoted

PIPE enum definitions are backward compatible. So move its definition
to adreno_common.xml.

What do you mean here by 'backward compatible'. Are they going to be
used on a6xx? a5xx? If not, then why do we need to move them?

Newer gen's introduce pipe enums which do not exist on older gens, but
the numeric values do not conflict.  Ie. each gen is a superset of the
previous.

BR,
-R

quoted

Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
---
 drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h        |  10 +-
 .../gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h  | 412 +++++++++---------
 .../gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h  | 324 +++++++--------
 .../gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h  | 462 ++++++++++-----------
 drivers/gpu/drm/msm/registers/adreno/a6xx.xml      |   4 +-
 .../gpu/drm/msm/registers/adreno/a7xx_enums.xml    |   7 -
 .../gpu/drm/msm/registers/adreno/adreno_common.xml |  11 +
 7 files changed, 617 insertions(+), 613 deletions(-)

--
With best wishes
Dmitry