Re: [PATCH v3 09/10] phy: qualcomm: m31-eusb2: Make clkref an optional resource
From: Konrad Dybcio <hidden>
Date: 2025-09-25 09:27:56
Also in:
linux-arm-msm, linux-phy, linux-usb, lkml
On 9/25/25 4:28 AM, Wesley Cheng wrote:
Some USB subsystems that utlize the M31 eUSB2 PHY doesn't require a clkref.
This is more likely "doesn't include a software-controllable" ref clock but that's "fine" Reviewed-by: Konrad Dybcio <redacted> Konrad
quoted hunk ↗ jump to hunk
One example is the Glymur platform, which contains 4 USB controllers that all utilize the M31 eUSB2 PHY. However, PHYs associated to the primary and secondary controllers do not require a clkref resource. Due to this, mark this as an optional clock. Reviewed-by: Dmitry Baryshkov <redacted> Signed-off-by: Wesley Cheng <redacted> --- drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c index 95cd3175926d..f8a00962f937 100644 --- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c@@ -267,7 +267,7 @@ static int m31eusb2_phy_probe(struct platform_device *pdev) if (IS_ERR(phy->reset)) return PTR_ERR(phy->reset); - phy->clk = devm_clk_get(dev, NULL); + phy->clk = devm_clk_get_optional(dev, NULL); if (IS_ERR(phy->clk)) return dev_err_probe(dev, PTR_ERR(phy->clk), "failed to get clk\n");