Re: [PATCH v7 2/4] net: can: rockchip: Refactor the rkcanfd_devtype_data structure
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2025-09-22 13:19:08
Also in:
linux-arm-kernel, linux-can, linux-rockchip, lkml
On 22.09.2025 15:15:41, Elaine Zhang wrote:
Add new function pointer: Encapsulate some hardware operation functions into rkcanfd_devtype_data to provide differentiated implementations for different models (such as RK3568v2/v3). Signed-off-by: Elaine Zhang <redacted>
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/can/rockchip/rockchip_canfd.h b/drivers/net/can/rockchip/rockchip_canfd.h index 93131c7d7f54..bcd26d23062b 100644 --- a/drivers/net/can/rockchip/rockchip_canfd.h +++ b/drivers/net/can/rockchip/rockchip_canfd.h@@ -436,9 +436,20 @@ enum rkcanfd_model { RKCANFD_MODEL_RK3568V3 = 0x35683, }; +struct rkcanfd_priv; + struct rkcanfd_devtype_data { enum rkcanfd_model model; u32 quirks; + void (*get_berr_counter)(struct rkcanfd_priv *priv, struct can_berr_counter *bec); + void (*interrupts_enable)(const struct rkcanfd_priv *priv); + void (*interrupts_disable)(const struct rkcanfd_priv *priv); + void (*fifo_setup)(struct rkcanfd_priv *priv);
Why do you make fifo setup a function pointer if it's only called from chip_start, which you make a function pointer, too? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachments
- signature.asc [application/pgp-signature] 488 bytes