RE: [EXT] Re: [PATCH v2 5/5] media: nxp: imx8-isi: Add ISI support for i.MX91

Hi Laurent,

Thanks for your review.

-----Original Message-----
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sent: Monday, September 22, 2025 6:28 AM
To: G.N. Zhou <redacted>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Rob Herring
[off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor Dooley
[off-list ref]; Shawn Guo [off-list ref]; Sascha Hauer
[off-list ref]; Pengutronix Kernel Team
[off-list ref]; Fabio Estevam [off-list ref]; Frank Li
[off-list ref]; linux-media@vger.kernel.org; devicetree@vger.kernel.org;
imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org
Subject: [EXT] Re: [PATCH v2 5/5] media: nxp: imx8-isi: Add ISI support for
i.MX91

Caution: This is an external email. Please take care when clicking links or
opening attachments. When in doubt, report the message using the 'Report this
email' button


Hi Guoniu,

Thank you for the patch.

On Fri, Sep 05, 2025 at 02:56:02PM +0800, Guoniu Zhou wrote:

quoted

The ISI module on i.MX91 implements only one channel and one parallel
camera input. As no input source selection is required, gasket ops are
unnecessary.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Guoniu Zhou <redacted>
---
 drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 12 ++++++++++++
drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h |  1 +
 2 files changed, 13 insertions(+)

diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c

b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
index

0155c75983f02f33f7f0669e73188222ebb5e816..c3d411ddf492eb27b372763c
e5d3

quoted

44a90c6ec524 100644

--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c

@@ -347,6 +347,17 @@ static const struct mxc_isi_plat_data

mxc_imx8ulp_data = {

quoted

      .has_36bit_dma          = false,
 };

+static const struct mxc_isi_plat_data mxc_imx91_data = {
+     .model                  = MXC_ISI_IMX91,
+     .num_ports              = 1,
+     .num_channels           = 1,
+     .reg_offset             = 0,
+     .ier_reg                = &mxc_imx8_isi_ier_v2,
+     .set_thd                = &mxc_imx8_isi_thd_v1,
+     .buf_active_reverse     = true,
+     .has_36bit_dma          = false,
+};
+
 static const struct mxc_isi_plat_data mxc_imx93_data = {
      .model                  = MXC_ISI_IMX93,
      .num_ports              = 1,

@@ -547,6 +558,7 @@ static const struct of_device_id mxc_isi_of_match[] =

{

quoted

      { .compatible = "fsl,imx8qm-isi", .data = &mxc_imx8qm_data },
      { .compatible = "fsl,imx8qxp-isi", .data = &mxc_imx8qxp_data },
      { .compatible = "fsl,imx8ulp-isi", .data = &mxc_imx8ulp_data },
+     { .compatible = "fsl,imx91-isi", .data = &mxc_imx91_data },
      { .compatible = "fsl,imx93-isi", .data = &mxc_imx93_data },
      { /* sentinel */ },
 };

diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h

b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
index

e84af5127e4e7938e55e31b7063bee5e2cd4cb11..3cbd35305af0f8026c4f76b5
eb5d

quoted

0864f8e36dc3 100644

--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h

@@ -160,6 +160,7 @@ enum model {
      MXC_ISI_IMX8QM,
      MXC_ISI_IMX8QXP,
      MXC_ISI_IMX8ULP,
+     MXC_ISI_IMX91,
      MXC_ISI_IMX93,
 };

The model field is unused, should we drop it ? That's a candidate for a separate
patch, for this patch

Agree.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

quoted

--
Regards,

Laurent Pinchart