Thread (18 messages) 18 messages, 7 authors, 2025-09-27

Re: [PATCH 0/2] Add support for Microchip EMC1812

From: Jonathan Cameron <jic23@kernel.org>
Date: 2025-09-20 11:33:51
Also in: linux-hwmon, linux-iio, lkml

On Wed, 17 Sep 2025 15:21:56 +0300
Marius Cristea [off-list ref] wrote:
This is the iio driver for EMC1812/13/14/15/33 multichannel Low-Voltage
Remote Diode Sensor Family. The chips in the family have one internal
and different numbers of external channels, ranging from 1 (EMC1812) to
4 channels (EMC1815).
Reading diodes in anti-parallel connection is supported by EMC1814, EMC1815
and EMC1833.

Current version of driver does not support interrupts, events and data
buffering.
Hi Marius,

For a temperature monitoring device like this, the opening question is
always why not HWMON?

There are various reasons we have temp sensors in IIO but mostly they are not
described as being monitors and this one is.

IIO may well be the right choice for this part, but good to lay out your
reasoning and +CC the hwmon list and maintainers.  There is an emc1403
driver already in hwmon, so perhaps compare and contrast with that.

I've +CC Jean, Guenter and list to save sending a v2 just to do that.

Jonathan

Differences related to previous patch:

v1:
- initial version.

Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
---
Marius Cristea (2):
      dt-bindings: iio: temperature: add support for EMC1812
      iio: temperature: add support for EMC1812

 .../iio/temperature/microchip,emc1812.yaml         | 223 ++++++
 MAINTAINERS                                        |   7 +
 drivers/iio/temperature/Kconfig                    |  10 +
 drivers/iio/temperature/Makefile                   |   1 +
 drivers/iio/temperature/emc1812.c                  | 792 +++++++++++++++++++++
 5 files changed, 1033 insertions(+)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250805-iio-emc1812-e666183b07b5

Best regards,
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help