Hi Rob,

Thanks for the review

quoted

+    description:
+      Syscon used to hold and release the reset of MIPI D-PHY

Reset? Sounds like you should be using the reset binding.

The Tesla FSD Soc does not have a dedicated reset controller. Instead, we
are using the
system controller which is MMIO Space handled by syscon driver, to assert or
de-assert the D-PHY
reset. So, I prefer to use syscon.

quoted

+
   phy-supply:
     description: The MIPI D-PHY digital power supply

@@ -93,7 +91,8 @@ properties:
             properties:
               data-lanes:
                 description:
-                  Note that 'fsl,imx7-mipi-csi2' only supports up to 2

data lines.

quoted

+                  Note that 'fsl,imx7-mipi-csi2' only supports up to 2

data

quoted

+                  lines.

Reformatting should be a separate patch.

Sure, I'll add new patch in next patchset.

quoted

                 minItems: 1
                 items:
                   - const: 1

@@ -115,7 +114,6 @@ required:
   - interrupts
   - clocks
   - clock-names
-  - power-domains
   - ports

 additionalProperties: false

@@ -124,20 +122,73 @@ allOf:
   - if:
       properties:
         compatible:
-          contains:
-            const: fsl,imx7-mipi-csi2
+          const: fsl,imx7-mipi-csi2

'contains' was correct. It is more future proof when there is another SoC

that

is backwards compatible with imx7.

Sure, I'll add new patch in next patchset.

quoted

     then:
+      properties:
+        clocks:
+          items:
+            - description: The peripheral clock (a.k.a. APB clock)
+            - description: The external clock (optionally used as the

pixel

quoted

+                clock)
+            - description: The MIPI D-PHY clock
+        clock-names:
+          items:
+            - const: pclk
+            - const: wrap
+            - const: phy
+        tesla,syscon-csis: false
+        fsl,num-channels: false

blank line

Will remove in nextpatchset.

quoted

       required:
+        - power-domains
         - phy-supply
         - resets
-    else:
+
+  - if:
+      properties:
+        compatible:
+          const: fsl,imx8mm-mipi-csi2
+    then:
       properties:
         clocks:
-          minItems: 4
+          items:
+            - description: The peripheral clock (a.k.a. APB clock)
+            - description: The external clock (optionally used as the

pixel

quoted

+                clock)
+            - description: The MIPI D-PHY clock
+            - description: The AXI clock
         clock-names:
-          minItems: 4
+          items:
+            - const: pclk
+            - const: wrap
+            - const: phy
+            - const: axi
+        tesla,syscon-csis: false
+        fsl,num-channels: false
         phy-supply: false
         resets: false

blank line

quoted

+      required:
+        - power-domains
+
+  - if:
+      properties:
+        compatible:
+          const: tesla,fsd-mipi-csi2
+    then:
+      properties:
+        clocks:
+          items:
+            - description: The peripheral clock (a.k.a. APB clock)
+            - description: The DMA clock

Wouldn't this be the same as the "AXI clock"?

According to v4.3 manual it is DMA clock.

quoted

+        clocks-names:
+          items:
+            - const: pclk
+            - const: aclk
+        phy-supply: false
+        resets: false
+        power-domains: false

blank line

Sure will remove in next patchset.

quoted

+      required:
+        - tesla,syscon-csis
+        - fsl,num-channels

 examples:
   - |
--
2.49.0

Regards,
Inbaraj E