On 9/16/2025 5:46 PM, Jerome Brunet wrote:

[ EXTERNAL EMAIL ]

On Tue 16 Sep 2025 at 17:30, Chuan Liu [off-list ref] wrote:

quoted

Hi Jerome:


On 9/16/2025 3:47 PM, Jerome Brunet wrote:

quoted

[ EXTERNAL EMAIL ]

On Tue 16 Sep 2025 at 10:06, Chuan Liu via B4 Relay [off-list ref] wrote:

quoted

This patch introduces new clock support for video processing components
including the encoder, demodulator and CVBS interface modules.

The related clocks have passed clk-measure verification.

Signed-off-by: Chuan Liu <redacted>
---
Changes in v5:
- Add Acked-by tags from Conor.
- Remove unnecessary flags as suggested by Jerome.

The request was "in an another change" ? Why was this ignored ?

Sorry to bother you. I'll drop the flags for 's4_cts_encl_sel' in this
series and submit a separate patch later to remove CLK_SET_RATE_PARENT
from enci/encp/cdac/hdmitx clk_muxes. Is that ok?

Why can't make it part of this series, as requested ?
It does not seems that hard to do.

The topic of this patch series is "add video-related clocks," so I'm
concerned that patches adding or removing flags for other clocks might
be considered off-topic.

In the next revision of this series, I will include a separate patch
to remove these flags and provide the appropriate commit message.

This is another unnecessary revision and the community will have to
review, because you ignored some feedback.

As noted by Krzysztof, you really need to pay more attention to the time
and effort other are spending reviewing your work.

I'm still a newcomer when it comes to upstreaming, and I'm not yet very
familiar with the rules and processes. I apologize for any inconvenience
this may have caused during this period, and I sincerely appreciate your
pointing out any issues with my patches.

quoted

quoted

quoted

- Link to v4: https://lore.kernel.org/r/20250909-add_video_clk-v4-0-5e0c01d47aa8@amlogic.com (local)

Changes in v4:
- Add Acked-by tags from Rob and Krzysztof.
- Fix compilation errors.
- Link to v3: https://lore.kernel.org/r/20250905-add_video_clk-v3-0-8304c91b8b94@amlogic.com (local)

Changes in v3:
- Rebase with Jerome's latest code base.
- Link to v2: https://lore.kernel.org/r/20250814-add_video_clk-v2-0-bb2b5a5f2904@amlogic.com (local)

Changes in v2:
- Removed lcd_an clock tree (previously used in meson series but obsolete in
newer chips).
- Removed Rob's 'Acked-by' tag due to dt-binding changes (Is it necessary?).
- Link to v1: https://lore.kernel.org/r/20250715-add_video_clk-v1-0-40e7f633f361@amlogic.com (local)

---
Chuan Liu (2):
        dt-bindings: clock: add video clock indices for Amlogic S4 SoC
        clk: amlogic: add video-related clocks for S4 SoC

   drivers/clk/meson/s4-peripherals.c                 | 206 ++++++++++++++++++++-
   .../clock/amlogic,s4-peripherals-clkc.h            |  11 ++
   2 files changed, 213 insertions(+), 4 deletions(-)
---
base-commit: 01f3a6d1d59b8e25a6de243b0d73075cf0415eaf
change-id: 20250715-add_video_clk-dc38b5459018

Best regards,

--
Jerome

--
Jerome