Re: [PATCH v6 2/3] drm: panel: nt36672a: Add support for novatek nt35596s panel

On Mon, Sep 15, 2025 at 05:06:51PM +0200, David Heidelberg wrote:

On 15/09/2025 13:11, Dmitry Baryshkov wrote:

quoted

On Mon, Sep 15, 2025 at 12:11:49PM +0200, David Heidelberg wrote:

quoted

On 15/09/2025 03:29, Dmitry Baryshkov wrote:

quoted

On Sat, Sep 13, 2025 at 09:19:48PM +0200, David Heidelberg via B4 Relay wrote:

quoted

From: Molly Sophia <redacted>

Novatek NT35596s is a generic DSI IC that drives command and video mode
panels.
Currently add support for the LCD panel from JDI connected with this IC,
as found on Xiaomi Mi Mix 2S phones.

Why are you adding it to the existing driver rather than adding a new
one?

Hello, originally it started as a standalone driver (see v2 patchset), but
got merged due to similarities.

I'm not sure, you had to get rid of the two command sets. On the other
hand, adding a new module will add a lot of boilerplate. Let's keep it
as is. Please add some notes to the commit message.

Ok, I found out in the meantime that Alexey is working on refactoring
nt36672a, so we’ll coordinate. I’ll likely need to rebase this changeset on
top of the refactored nt36672a, or possibly move it into a separate driver.

See https://github.com/sdm660-mainline/linux/pull/114/commits

I think it fits even more after refactoring. I hope Alexey will post the
refacrorings soon.

quoted

quoted

v2 patchset:
https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg404290.html

If it's desired, I can switch it back to the standalone driver.

quoted

quoted

Signed-off-by: Molly Sophia <redacted>
Signed-off-by: Arnaud Ferraris <redacted>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
   drivers/gpu/drm/panel/Kconfig                  |   7 +-
   drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 225 ++++++++++++++++++++++++-
   2 files changed, 222 insertions(+), 10 deletions(-)

   MODULE_AUTHOR("Sumit Semwal [off-list ref]");
-MODULE_DESCRIPTION("NOVATEK NT36672A based MIPI-DSI LCD panel driver");
+MODULE_AUTHOR("Molly Sophia [off-list ref]");

??

What's wrong with it?

I thought that the module can have only one MODULE_AUTHOR declaration, I
was wrong. This is fine.

Yeah, it's not usual to have more than one.

quoted

quoted

David

quoted

quoted

+MODULE_DESCRIPTION("NOVATEK NT36672A/NT35596S based MIPI-DSI LCD panel driver");
   MODULE_LICENSE("GPL");

-- 
2.51.0

-- 
David Heidelberg

-- 
David Heidelberg

-- 
With best wishes
Dmitry