On Wed, Sep 10, 2025 at 5:07 AM Krzysztof Kozlowski [off-list ref] wrote:
On 10/09/2025 11:39, Krzysztof Kozlowski wrote:
quoted
On 06/09/2025 22:16, Aaron Kling via B4 Relay wrote:
quoted
+
+static int tegra_emc_interconnect_init(struct tegra210_emc *emc)
+{
+ const struct tegra_mc_soc *soc = emc->mc->soc;
+ struct icc_node *node;
+ int err;
+
+ emc->icc_provider.dev = emc->dev;
+ emc->icc_provider.set = emc_icc_set;
+ emc->icc_provider.data = &emc->icc_provider;
+ emc->icc_provider.aggregate = soc->icc_ops->aggregate;
+ emc->icc_provider.xlate_extended = emc_of_icc_xlate_extended;
+ emc->icc_provider.get_bw = tegra_emc_icc_get_init_bw;
+
+ icc_provider_init(&emc->icc_provider);
+
+ /* create External Memory Controller node */
+ node = icc_node_create(TEGRA_ICC_EMC);
+ if (IS_ERR(node)) {
+ err = PTR_ERR(node);
+ goto err_msg;
return dev_err_probe
I will send patches to fix existing code. I also found some more issues
which I would like to implement here.
I apologize for coming with all this at v3. I should point out things a
bit earlier, although how this patchset was organized also affected review.
Anyway my comments are mostly non-critical things, so v3 is late to
bring these, I understand. That's on me. I appreciate your work and
please do not get discouraged with my comments.
I understand and that's fine. Get it done right the first time so it
doesn't have to be redone later. I will try to get a new revision out
this week once I cycle back around to the relevant devices here.
Aaron