Re: [PATCH v2 1/4] dt-bindings: media: ti,ds90ub953: Add third cell for GPIO controller
From: Rob Herring <robh@kernel.org>
Date: 2025-09-15 02:10:09
Also in:
linux-media, lkml
On Thu, Sep 11, 2025 at 04:44:22PM +0800, Guoniu Zhou wrote:
quoted hunk ↗ jump to hunk
Add third cell for GPIO controller to select GPIO output source. 0 to select output source from local GPIO data, 1 to select output source from remote compatible deserializer GPIO data. Signed-off-by: Guoniu Zhou <redacted> --- Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml | 8 +++++--- Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-)diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml index 2e129bf573b79e0ca8f25b4ec5fc6ea76c50abd7..de759413a36060d3be6f2c3b67de48ee6e4d29f2 100644 --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml@@ -19,10 +19,12 @@ properties: - ti,ds90ub971-q1 '#gpio-cells': - const: 2 + const: 3 description: First cell is the GPIO pin number, second cell is the flags. The GPIO pin number must be in range of [0, 3]. + Third cell is GPIO output source(0 for local gpio data, 1 for remote + gpio data from remote compatible deserializer).
Changing the cell size is an ABI break unless 3 cells was supported in OS before which I don't think it would be given GPIO cell meaning is pretty standardized. You could just all a flag to the 2nd cell I think. Or if 0-3 are local GPIOs, then make remote ones a different range. Rob