Thread (10 messages) 10 messages, 3 authors, 2025-09-24

Re: [PATCH v18 1/3] dt-bindings: i2c: aspeed,i2c.yaml: add transfer-mode and global-regs properties and update example

From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2025-09-12 08:59:00
Also in: linux-arm-kernel, linux-aspeed, linux-i2c, lkml, openbmc

Hi Ryan,
And AST2600 i2c controller have two register mode, one is legacy
register layout which is mix controller/target register control
together, another is new mode which is separate controller/target
register control.
OK, but the ast2400 and ast2500 I2C peripherals - which this binding
also describes - do not have that facility. Given the 2600 is a distinct
peripheral (as discussed on the v16 series), this would seem to warrant
a distinct binding.

Should this be split out into an ast2600-specific binding, to reflect
that it is different hardware? The reference to the global registers and
transfer modes would then be added only to the ast2600-i2c-bus binding.

Cheers,


Jeremy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help