Re: [PATCH 2/2] arm64: dts: marvell: armada-cp11x: Add default ICU address cells
From: Gregory CLEMENT <gregory.clement@bootlin.com>
Date: 2025-09-12 05:21:59
Also in:
linux-arm-kernel, lkml
Krzysztof Kozlowski [off-list ref] writes:
Add missing address-cells 0 to the ICU interrupt node to silence W=1
warning:
armada-cp11x.dtsi:547.3-47: Warning (interrupt_map): /cp0-bus/pcie@f2600000:interrupt-map:
Missing property '#address-cells' in node /cp0-bus/bus@f2000000/interrupt-controller@1e0000/interrupt-controller@10, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <redacted>Applied on mvebu/dt64 Thanks, Gregory
quoted hunk ↗ jump to hunk
--- arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi index a057e119492f..d9d409eac259 100644 --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi@@ -202,6 +202,7 @@ CP11X_LABEL(icu): interrupt-controller@1e0000 { CP11X_LABEL(icu_nsr): interrupt-controller@10 { compatible = "marvell,cp110-icu-nsr"; reg = <0x10 0x20>; + #address-cells = <0>; #interrupt-cells = <2>; interrupt-controller; msi-parent = <&gicp>;-- 2.48.1
-- Grégory CLEMENT, Bootlin Embedded Linux and Kernel engineering https://bootlin.com