Re: [PATCH 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl

Hi Gary!

On Tue, Sep 9, 2025 at 5:30 AM Gary Yang [off-list ref] wrote:

First share a good news with you. It's that We have verified the new scheme pass on Radax O6 board.

That's great!

We just have a question before submit new patchs. As you know, there are some macros defines in dts/dtsi file.

Where should these defines locate? We found these defines locate in include/dt-bindings/pinctrl/

mt7623-pinfunc.h on MT7623 platform. We don't find arch/arm64/boot/dts/*/* -pinmux-props.dtsi.

What's your suggestion? Please kindly remind me if I misunderstand and miss anything.

Yes these are old habits from Mediatek platforms which are bad.

Since they are not bindings, just convenience defines, I would suggest you move
the stuff from
include/dt-bindings/pinctrl/pads-sky1.h

Into
arch/arm64/boot/dts/cix/pads-sky1[.h|.dtsi]

I am not aware that using .h or .dtsi has any semantic difference,
maybe the DT experts can tell. Maybe use pads-sky1.h to be on
the safe side.

Yours,
Linus Walleij