Re: [PATCH 3/4] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-09-10 07:01:12
Also in:
linux-arm-kernel, linux-arm-msm, linux-media, lkml
On 09/09/2025 13:42, Vikram Sharma wrote:
quoted hunk ↗ jump to hunk
From: Nihal Kumar Gupta <redacted> Enable IMX577 sensor using the CCI1 interface on Monaco EVK. Camera reset is controlled through an I2C expander, and power supply is managed via tlmm GPIO74. Co-developed-by: Ravi Shankar <redacted> Signed-off-by: Ravi Shankar <redacted> Co-developed-by: Vishal Verma <redacted> Signed-off-by: Vishal Verma <redacted> Signed-off-by: Nihal Kumar Gupta <redacted> Signed-off-by: Vikram Sharma <redacted> --- arch/arm64/boot/dts/qcom/Makefile | 4 + .../boot/dts/qcom/monaco-evk-camera.dtso | 98 +++++++++++++++++++ 2 files changed, 102 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/monaco-evk-camera.dtsodiff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 0e4e0e0b833b..714eb4badf5a 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile@@ -31,6 +31,10 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp453.dtb dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp454.dtb dtb-$(CONFIG_ARCH_QCOM) += lemans-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += monaco-evk.dtb + +monaco-evk-camera-dtbs := monaco-evk.dtb monaco-evk-camera.dtbo + +dtb-$(CONFIG_ARCH_QCOM) += monaco-evk-camera.dtb
Missing proper indentation before +=. Did you even look at this code while changing? Or you just copied it from downstream and sent?
quoted hunk ↗ jump to hunk
dtb-$(CONFIG_ARCH_QCOM) += msm8216-samsung-fortuna3g.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtbdiff --git a/arch/arm64/boot/dts/qcom/monaco-evk-camera.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-camera.dtso new file mode 100644 index 000000000000..5831b4de6eca --- /dev/null +++ b/arch/arm64/boot/dts/qcom/monaco-evk-camera.dtso@@ -0,0 +1,98 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved. + */ + +/* Camera Sensor overlay on top of Monaco EVK Core Kit */ + +/dts-v1/; +/plugin/; + +#include <dt-bindings/clock/qcom,sa8775p-camcc.h> +#include <dt-bindings/gpio/gpio.h> + +&{/} { + vreg_cam1_2p8: vreg_cam1_2p8 {
Don't send us downstream code. You need to rewrite everything, not just pieces. Best regards, Krzysztof