Thread (23 messages) 23 messages, 5 authors, 2025-09-09

Re: [PATCH phy 13/14] dt-bindings: phy: lynx-28g: add compatible strings per SerDes and instantiation

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2025-09-05 15:41:56
Also in: linux-phy, lkml

On Fri, Sep 05, 2025 at 10:29:33AM +0200, Krzysztof Kozlowski wrote:
quoted
 properties:
   compatible:
-    enum:
-      - fsl,lynx-28g
+    oneOf:
+      - items:
+          - const: fsl,lynx-28g
Don't change that part. Previous enum was correct. You want oneOf and
enum.
Combining the feedback from Conor and Josua, I should only be permitting
the use of "fsl,lynx-28g" as a fallback to "fsl,lx216{0,2}a-serdes{1,2}",
or standalone. The description below achieves just that. Does it look ok
to you?

properties:
  compatible:
    oneOf:
      - enum:
          - fsl,lx2160a-serdes1
          - fsl,lx2160a-serdes2
          - fsl,lx2160a-serdes3
          - fsl,lx2162a-serdes1
          - fsl,lx2162a-serdes2
      - const: fsl,lynx-28g
        deprecated: true
      - items:
          - const: fsl,lx2160a-serdes1
          - const: fsl,lynx-28g
        deprecated: true
      - items:
          - const: fsl,lx2160a-serdes2
          - const: fsl,lynx-28g
        deprecated: true
      - items:
          - const: fsl,lx2162a-serdes1
          - const: fsl,lynx-28g
        deprecated: true
      - items:
          - const: fsl,lx2162a-serdes2
          - const: fsl,lynx-28g
        deprecated: true
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help