Thread (30 messages) 30 messages, 5 authors, 2025-09-05

Re: [PATCH v3 05/14] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C256C

From: Dmitry Baryshkov <hidden>
Date: 2025-09-04 20:16:30
Also in: linux-arm-msm, linux-i2c, linux-mmc, lkml, netdev

On Fri, Sep 05, 2025 at 01:07:10AM +0530, Wasim Nazir wrote:
On Thu, Sep 04, 2025 at 07:43:27PM +0300, Dmitry Baryshkov wrote:
quoted
On Thu, Sep 04, 2025 at 10:09:01PM +0530, Wasim Nazir wrote:
quoted
Add the compatible for 256Kb EEPROM from Giantec.
Why? Don't describe the change, describe the reason for the change.
Let me know if this properly describe the reason:

---
dt-bindings: eeprom: at24: Add compatible for Giantec GT24C256C

The gt24c256c is another 24c256 compatible EEPROM, and does not
follow the generic name matching, so add a separate compatible for it.
This ensures accurate device-tree representation and enables proper
kernel support for systems using this part.
LGTM
---
quoted
quoted
Signed-off-by: Wasim Nazir <redacted>
---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index 0ac68646c077..50af7ccf6e21 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -143,6 +143,7 @@ properties:
           - const: atmel,24c128
       - items:
           - enum:
+              - giantec,gt24c256c
               - puya,p24c256c
           - const: atmel,24c256
       - items:
-- 
2.51.0
-- 
With best wishes
Dmitry
-- 
Regards,
Wasim
-- 
With best wishes
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help