On Mon, Sep 01, 2025 at 09:38:25PM GMT, Nitin Rawat wrote:

On 8/21/2025 5:18 PM, Krzysztof Kozlowski wrote:

quoted

On 21/08/2025 13:24, Ram Kumar Dwivedi wrote:

quoted

From: Nitin Rawat <redacted>

Remove the ufshcd_res_info structure and associated enum ufshcd_res
definitions from the UFS host controller header. These were previously
used for MCQ resource mapping but are no longer needed following recent
refactoring to use direct base addresses instead of multiple separate
resource regions

Signed-off-by: Nitin Rawat <redacted>

Incomplete SoB chain.

But anyway this makes no sense as independent patch. First you remove
users of it making it redundant... and then you remove it? No.

Hi Krzysztof,

The driver changes are in the UFS Qualcomm platform driver, which uses the
definitions, while ufshcd.h is part of the UFS core driver. Hence kept in 2
separate patch.

No, that is not a logical split. When the users are removed, the unused
definitions also have to be removed even if the definitions are in a different
file.

So I believe you need to remove 'ufshcd_res_info' in patch 1 and 'ufshcd_res' in
patch 2.

- Mani

-- 
மணிவண்ணன் சதாசிவம்