Thread (14 messages) 14 messages, 2 authors, 2025-09-03

RE: [PATCH v4 1/6] dt-bindings: phy: ti,tcan104x-can: Document NXP TJA105X/1048

From: Peng Fan <peng.fan@nxp.com>
Date: 2025-09-03 06:49:51
Also in: imx, linux-arm-kernel, linux-can, linux-phy, lkml

Subject: RE: [PATCH v4 1/6] dt-bindings: phy: ti,tcan104x-can:
Document NXP TJA105X/1048
...
Thanks again for the detailed reading into datasheet.

Yes. But I would like to only keep one compatible "nxp,tja1051" from a
board design level, EN could be always tied to high for TJA1051T/E. So
to dt-binding, EN it is optional for all TJA1051 variants.

I am thinking to use below compatible in V4 for the devices added in
this patch. Does this look good to you?

      - items:
          - const: nxp,tja1057
          - const: nxp,tja1051
      - enum:
          ....
          - nxp,tja1048
          - nxp,tja1051
Considering TJA1057 does not have EN, I may need to use:
      - enum:                                                                                       
          ....
          - nxp,tja1048                                                                             
          - nxp,tja1051                                                                             
          - nxp,tja1057                                                                             
         ....

Thanks,
Peng.
          ....
quoted
quoted
If we need to handle differently, I need to add a new optional
property

silent-gpios:
  description:
    gpio node to toggle silent signal on transceiver
  minItems: 1
Ye, I think so. And probably add some if/then to use it instead of
standby on the relevant chips.
Yes. Agree.

Thanks,
Peng.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help