Re: [PATCH v10 10/13] arm64: dts: rockchip: add the vip node to px30
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Date: 2025-08-28 13:25:07
Also in:
linux-arm-kernel, linux-media, linux-rockchip, lkml
On 19/08/2025 01:26, Michael Riesch via B4 Relay wrote:
quoted hunk ↗ jump to hunk
From: Mehdi Djait <mehdi.djait@bootlin.com> Add the device tree node for the PX30 Video Input Processor (VIP). Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com> [added cosmetic changes] Signed-off-by: Michael Riesch <redacted> Signed-off-by: Michael Riesch <michael.riesch@collabora.com> --- arch/arm64/boot/dts/rockchip/px30.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi index 46f64cd33b9b..ef52879d6a73 100644 --- a/arch/arm64/boot/dts/rockchip/px30.dtsi +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi@@ -1280,6 +1280,18 @@ isp_mmu: iommu@ff4a8000 { #iommu-cells = <0>; }; + cif: video-capture@ff490000 { + compatible = "rockchip,px30-vip"; + reg = <0x0 0xff490000 0x0 0x200>; + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>; + clock-names = "aclk", "hclk", "pclk"; + power-domains = <&power PX30_PD_VI>; + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; + reset-names = "axi", "ahb", "pclkin"; + status = "disabled"; + }; + qos_gmac: qos@ff518000 { compatible = "rockchip,px30-qos", "syscon"; reg = <0x0 0xff518000 0x0 0x20>;
Now that I look at the rockchip dtsi it appears newline scarcity is the norm, you can disregard my suggestion for your example in the previous patch so. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>