On Fri, 2025-07-18 at 08:44 +0200, AngeloGioacchino Del Regno wrote:

External email : Please do not click links or open attachments until
you have verified the sender or the content.


Il 11/07/25 11:44, Cathy Xu ha scritto:

quoted

Add the pinctrl header file on MediaTek mt8189.

Signed-off-by: Cathy Xu <redacted>
---
  arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h | 1125
+++++++++++++++++
  1 file changed, 1125 insertions(+)
  create mode 100644 arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h

diff --git a/arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h

b/arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h
new file mode 100644
index 000000000000..f9c270ebab89

--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h

@@ -0,0 +1,1125 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2025 MediaTek Inc.
+ * Author: Lei Xue <lei.xue@mediatek.com>
+ *         Cathy Xu <ot_cathy.xu@mediatek.com>
+ */
+
+#ifndef __MT8189_PINFUNC_H
+#define __MT8189_PINFUNC_H
+
+#include "mt65xx.h"
+

..snip..

quoted

+#define PINMUX_GPIO27__FUNC_GPIO27 (MTK_PIN_NO(27) | 0)
+#define PINMUX_GPIO27__FUNC_DP_TX_HPD (MTK_PIN_NO(27) | 1)

quoted

+#define PINMUX_GPIO27__FUNC_mbistreaden_trigger (MTK_PIN_NO(27) |
2)

                                ^^^^^^^^^^^^^^^^^^^
Please fix: this has to be uppercase as much as the other
definitions.

  Thank you for your review. It will be fixed in next version.

quoted

+#define PINMUX_GPIO27__FUNC_MD32_0_GPIO0 (MTK_PIN_NO(27) | 3)
+#define PINMUX_GPIO27__FUNC_TP_UCTS1_VCORE (MTK_PIN_NO(27) | 4)
+#define PINMUX_GPIO27__FUNC_CMVREF4 (MTK_PIN_NO(27) | 5)
+#define PINMUX_GPIO27__FUNC_EXTIF0_ACT (MTK_PIN_NO(27) | 6)
+#define PINMUX_GPIO27__FUNC_ANT_SEL0 (MTK_PIN_NO(27) | 7)
+
+#define PINMUX_GPIO28__FUNC_GPIO28 (MTK_PIN_NO(28) | 0)
+#define PINMUX_GPIO28__FUNC_EDP_TX_HPD (MTK_PIN_NO(28) | 1)
+#define PINMUX_GPIO28__FUNC_mbistwriteen_trigger (MTK_PIN_NO(28) |
2)

same here

  It will be fixed in next version.

quoted

+#define PINMUX_GPIO28__FUNC_MD32_1_GPIO0 (MTK_PIN_NO(28) | 3)
+#define PINMUX_GPIO28__FUNC_TP_URTS1_VCORE (MTK_PIN_NO(28) | 4)
+#define PINMUX_GPIO28__FUNC_EXTIF0_PRI (MTK_PIN_NO(28) | 6)
+#define PINMUX_GPIO28__FUNC_ANT_SEL1 (MTK_PIN_NO(28) | 7)
+

Cheers,
Angelo