On Mon, Aug 25, 2025 at 9:38 AM Conor Dooley [off-list ref] wrote:

On Sun, Aug 24, 2025 at 09:48:10PM -0700, Rosen Penev wrote:

quoted

The ath9k driver has various pin GPIO numbers for different chipsets
which are not always correct for every device.

Add bindings to specify the correct number and if it should be
active-low.

Signed-off-by: Rosen Penev <redacted>
---
 .../bindings/net/wireless/qca,ath9k.yaml         | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
index d16ca8e0a25d..bbac017d34d0 100644
--- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml

@@ -50,6 +50,18 @@ properties:

   ieee80211-freq-limit: true

+  led:
+    type: object
+    additionalProperties: false
+    properties:
+      reg:
+        maxItems: 1
+
+      led-active-low:

How come you are not including leds/common.yaml and making use of the
active-low property defined there? Seems to be in use by mediatek,mt76.yaml

Probably makes more sense to use active-high instead. Will do so in next series.

quoted

+        description:
+          LED is enabled with ground signal.
+        type: boolean
+
   qca,no-eeprom:
     $ref: /schemas/types.yaml#/definitions/flag
     description:

@@ -102,5 +114,9 @@ examples:
         compatible = "qca,ar9130-wifi";
         reg = <0x180c0000 0x230000>;
         interrupts = <2>;
+        led {
+          reg = <0>;
+          led-active-low;
+        };
       };
     };
--

2.50.1