On Thu, Aug 21, 2025 at 10:41:03AM +0300, Andy Shevchenko wrote:

On Thu, Aug 21, 2025 at 6:02 AM Dixit Parmar [off-list ref] wrote:

quoted

On Wed, Aug 20, 2025 at 05:08:38PM +0300, Andy Shevchenko wrote:

...

quoted

quoted

quoted

 st_magn-$(CONFIG_IIO_BUFFER) += st_magn_buffer.o
 obj-$(CONFIG_IIO_ST_MAGN_I2C_3AXIS) += st_magn_i2c.o
 obj-$(CONFIG_IIO_ST_MAGN_SPI_3AXIS) += st_magn_spi.o

+obj-$(CONFIG_INFINEON_TLV493D)             += tlv493d.o
+
 obj-$(CONFIG_SENSORS_HMC5843)              += hmc5843_core.o
 obj-$(CONFIG_SENSORS_HMC5843_I2C)  += hmc5843_i2c.o
 obj-$(CONFIG_SENSORS_HMC5843_SPI)  += hmc5843_spi.o

I haven't got the ordering rules here and in Kconfig. Can it be alphabetical?

From what I can see, the order is alphabetical based on the CONFIG option in the
Makefile and Kconfig, and I kept CONFIG_INFINEO_TLV493D after CONFIG_IIO_ST*.
Isn't it in correct order? or my understanding is incorrect?

I dunno, The file name there is with the vendor prefix, in many cases
the configuration option is with vendor prefix as well, but the file.

Hi Jonathan, Can you please suggest best possible way here?

quoted

quoted

Interestingly that you have used 100 limit and suddenly don't do it here
and maybe elsewhere. Why inconsistent style? Please, go through the whole
file and make sure the style is consistent in all of the aspects:
- C style used
- comments style (one-line and multi-line)
- indentation
- etc.

I tried to follow 80 limit(except few places where it was just on border or not
clear to read). I belive the standard is to use 80 limit(correct me if I referred
wrong place) and I will recheck to meet that.

There are two standards, the old and strict one -- 80 characters, and
this subsystem _tries_ to follow it and relaxed with 100 limit.
The exceptions are possible when it affects readability.

Understood, I will go with 100 limit and make sure everything is well within it.

Thanks,
Dixit