Re: [PATCH v2 6/9] dt-bindings: nvme: apple,nvme-ans: Add Apple A11
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-08-19 09:18:56
Also in:
asahi, linux-arm-kernel, linux-iommu, linux-nvme, lkml
On Mon, Aug 18, 2025 at 04:42:59PM +0800, Nick Chan wrote:
quoted hunk ↗ jump to hunk
Add ANS2 NVMe bindings for Apple A11 SoC. Signed-off-by: Nick Chan <redacted> --- .../devicetree/bindings/nvme/apple,nvme-ans.yaml | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)diff --git a/Documentation/devicetree/bindings/nvme/apple,nvme-ans.yaml b/Documentation/devicetree/bindings/nvme/apple,nvme-ans.yaml index fc6555724e1858e8a16f6750302ff0ad9c4e5b88..4127d7b0a0f066fd0e144b32d1b676e3406b9d5a 100644 --- a/Documentation/devicetree/bindings/nvme/apple,nvme-ans.yaml +++ b/Documentation/devicetree/bindings/nvme/apple,nvme-ans.yaml@@ -11,12 +11,14 @@ maintainers: properties: compatible: - items: - - enum: - - apple,t8103-nvme-ans2 - - apple,t8112-nvme-ans2 - - apple,t6000-nvme-ans2 - - const: apple,nvme-ans2 + oneOf: + - const: apple,t8015-nvme-ans2 + - items: + - enum: + - apple,t8103-nvme-ans2 + - apple,t8112-nvme-ans2 + - apple,t6000-nvme-ans2 + - const: apple,nvme-ans2
When some months ago this pattern of generic fallback appeared, I believe I commented it is bad idea. So now months later we have a proof - generic fallback is useless and you should have been using SoC specific compatibles from the start. Now it is just confusing and this broken pattern will be spreading more and more, because you folks put generic compatibles everywhere. Best regards, Krzysztof