Hi Stephan,

On Thu, 14 Aug 2025 at 15:47, Stephan Gerhold
[off-list ref] wrote:

On Thu, Aug 14, 2025 at 04:21:09PM +0200, Neil Armstrong wrote:

quoted

On 09/08/2025 00:28, Christopher Obbard wrote:

quoted

On Mon, 4 Aug 2025 at 14:13, Johan Hovold [off-list ref] wrote:

quoted

On Thu, Jul 31, 2025 at 09:51:26PM +0100, Christopher Obbard wrote:

quoted

The eDP controller has an HPD GPIO. Describe it in the device tree
for the generic T14s model, as the HPD GPIO is used in both the
OLED and LCD models which inherit this device tree.

quoted

@@ -5779,6 +5779,11 @@ tlmm: pinctrl@f100000 {
                       gpio-ranges = <&tlmm 0 0 239>;
                       wakeup-parent = <&pdc>;

+                     edp_hpd_active: edp-hpd-active-state {

The node name and label needs an index as this SoC has two edp hpd pins
as I already pointed out.

Sure. After looking at the schematics this should be called
edp0_hpd_active. I will fix this in the next revision.

quoted

quoted

+                             pins = "gpio119";
+                             function = "edp0_hot";

And you also need to configure the bias somewhere as you should not rely
on the firmware having configured things for you (as I also pointed out
before).

On my T14s the internal pull-up has been disabled.

I am still unsure of what else needs to be set here. Can you help me
with the correct settings?

Just add bias-disable;

I sent a patch fixing this for all the X1 devices upstream earlier [1],
so you could also just send v7 with just the second patch of your
series.

Sure. I will do so and base my next version on your patchset.

The bias-disable is really somewhat device-specific (what if there is no
pull down on the device side and someone disconnects the panel
entirely?), so I put it into each board DT separately like Johan
requested on v5. We have the same for the PCIe pinctrl.

Thanks,
Stephan

[1]: https://lore.kernel.org/linux-arm-msm/20250814-x1e80100-add-edp-hpd-v1-0-a52804db53f6@linaro.org/T/ (local)