Re: [PATCH v3 4/8] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-08-14 08:50:31
Also in:
linux-arm-kernel, linux-mmc, lkml
On Tue, Aug 12, 2025 at 08:31:06PM +0800, Albert Yang wrote:
Add device tree binding documentation for the Black Sesame Technologies (BST) DWCMSHC SDHCI controller. This binding describes the required and optional properties for the bst,c1200-dwcmshc-sdhci compatible controller, including register layout, interrupts, bus width, clock configuration, and other controller-specific features.
Please drop this paragraph, it's completely redundant. You should rather describe the hardware.
quoted hunk ↗ jump to hunk
Signed-off-by: Ge Gordon <gordon.ge@bst.ai> Signed-off-by: Albert Yang <redacted> --- Changes for v3: - Switch reg schema from maxItems to explicit items with per-entry descriptions - Improve example: add irq.h include and wrap under a bus node with address/size cells - Drop status = "disabled" from example; keep example concise - Add Signed-off-by: Ge Gordon Changes for v2: - Simplified description, removed redundant paragraphs - Updated $schema to reference mmc-specific scheme - Corrected compatible to add soc name (bst,c1200-dwcmshc-sdhci) - Removed all redundant property descriptions - Dropped invalid mmc_crm_base/size properties, use reg for all address ranges - Cleaned up required properties to only essential entries - Standardized example DTS format, fixed reg syntax and property ordering - Removed additionalProperties: true --- .../bindings/mmc/bst,dwcmshc-sdhci.yaml | 70 +++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.yamldiff --git a/Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.yaml new file mode 100644 index 000000000000..aa72ce60259f --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.yaml@@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mmc/bst,dwcmshc-sdhci.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Black Sesame Technologies DWCMSHC SDHCI Controller + +maintainers: + - Ge Gordon <gordon.ge@bst.ai> + +allOf: + - $ref: mmc-controller.yaml#
You want sdhci-common.yaml instead.
+ +properties: + compatible: + const: bst,c1200-dwcmshc-sdhci
Keep just one name, so bst,c1200-dwcmshc (sdhci is redundant, right? Do you have more than one dwcmshc?)
+ + reg: + items: + - description: Core SDHCI registers + - description: CRM registers + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1
Best regards, Krzysztof