Re: [PATCH net-next v5 2/5] net: spacemit: Add K1 Ethernet MAC

From
Vivian Wang <hidden>
Date
2025-08-12 03:11:51
Also in
linux-riscv, lkml, netdev, spacemit
Reply to
Andrew Lunn, 2025-08-12
Hi Andrew,

On 8/12/25 10:17, Andrew Lunn wrote:
quoted
+/* Caller must hold stats_lock */
+static void emac_stats_update(struct emac_priv *priv)
+{
+	u64 *tx_stats_off = (u64 *)&priv->tx_stats_off;
+	u64 *rx_stats_off = (u64 *)&priv->rx_stats_off;
+	u64 *tx_stats = (u64 *)&priv->tx_stats;
+	u64 *rx_stats = (u64 *)&priv->rx_stats;
+	u32 i, res;
Rather than the comment, you could do:

	assert_spin_locked(priv->stats_lock);
Thanks, I'll use assert_spin_locked.

I don't think there's anything else that needs a similar assertion, but
I'll check for sure and update next version.

Vivian "dramforever" Wang

	Andrew
  
Thread (12 messages) 12 messages, 3 authors, last reply 2025-08-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help