Re: [PATCH v3 7/9] arm64: dts: imx943: Add display pipeline nodes
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-08-07 07:31:49
Also in:
imx, linux-arm-kernel, lkml
On Wed, Aug 06, 2025 at 06:05:14PM +0300, Laurentiu Palcu wrote:
quoted hunk ↗ jump to hunk
Add display controller and LDB support in imx943. Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com> --- arch/arm64/boot/dts/freescale/imx943.dtsi | 55 ++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-)diff --git a/arch/arm64/boot/dts/freescale/imx943.dtsi b/arch/arm64/boot/dts/freescale/imx943.dtsi index 657c81b6016f2..70dec03c5608e 100644 --- a/arch/arm64/boot/dts/freescale/imx943.dtsi +++ b/arch/arm64/boot/dts/freescale/imx943.dtsi@@ -148,7 +148,7 @@ l3_cache: l3-cache { }; }; - clock-ldb-pll-div7 { + clock_ldb_pll_div7: clock-ldb-pll-div7 { compatible = "fixed-factor-clock"; #clock-cells = <0>; clocks = <&scmi_clk IMX94_CLK_LDBPLL>;@@ -174,9 +174,62 @@ dispmix_csr: syscon@4b010000 { lvds_csr: syscon@4b0c0000 { compatible = "nxp,imx94-lvds-csr", "syscon"; reg = <0x0 0x4b0c0000 0x0 0x10000>; + #address-cells = <1>; + #size-cells = <1>; clocks = <&scmi_clk IMX94_CLK_DISPAPB>; #clock-cells = <1>; power-domains = <&scmi_devpd IMX94_PD_DISPLAY>; + + ldb: ldb@4 { + compatible = "fsl,imx94-ldb"; + reg = <0x4 0x4>, <0x8 0x4>; + #address-cells = <1>; + #size-cells = <0>;
Why? There are no children with addressing. You never tested it because this would easily be flagged by tools.
+ reg-names = "ldb", "lvds";
Follow DTS coding style. Best regards, Krzysztof