Thread (6 messages) 6 messages, 5 authors, 2025-08-01

RE: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

From: Biju Das <biju.das.jz@bp.renesas.com>
Date: 2025-08-01 10:10:49
Also in: linux-renesas-soc, lkml

Hi Krzysztof Kozlowski,
-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 01 August 2025 10:16
Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

On 01/08/2025 10:11, Biju Das wrote:
quoted
Hi Geert,

Thanks for the feedback.
quoted
-----Original Message-----
From: Geert Uytterhoeven <geert@linux-m68k.org>
Sent: 01 August 2025 08:30
Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for
deleting node

Hi Biju,

On Thu, 31 Jul 2025 at 14:51, Biju [off-list ref] wrote:
quoted
From: Biju Das <biju.das.jz@bp.renesas.com>

Fix typo for deleting node 'channel@0'->'channel0'.

Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable
CANFD channel 1")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Thanks for your patch!
quoted
--- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
@@ -48,7 +48,7 @@ sound_card {
 #if (SW_SCIF_CAN || SW_RSPI_CAN)
 &canfd {
        pinctrl-0 = <&can1_pins>;
-       /delete-node/ channel@0;
+       /delete-node/ channel0;
As pointed out by Rob's bot, you must not delete this node.
Instead, set channel0's status to disabled.
OK. Will fix this in next version.
Please TEST your patch before sending it. This would avoid this entire discussion.
Sorry for that. Will take care next time.

Cheers,
Biju
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help