Thread (15 messages) 15 messages, 5 authors, 2025-08-01

Re: [PATCH v2 2/3] pinctrl: tegra: Add Tegra186 pinmux driver

From: Thierry Reding <hidden>
Date: 2025-08-01 09:35:58
Also in: linux-gpio, linux-tegra, lkml

On Fri, Aug 01, 2025 at 01:33:10AM -0500, Aaron Kling wrote:
On Wed, Jul 23, 2025 at 6:08 AM Linus Walleij [off-list ref] wrote:
quoted
On Mon, Jul 14, 2025 at 7:45 AM Aaron Kling [off-list ref] wrote:
quoted
I started looking at the pinmux scripts a few days ago, but updating
the pinmux driver import/export for the t194 style spiderwebbed out of
control quickly. I expected it to be hairy, but that was an
underestimation. Doesn't help that I'm not the most proficient at
python either. I'll continue the effort later, but if someone with
more familiarity wants to try, it might be quicker.
If this means people with 186 dev boards cannot use mainline
Linux and they would if this driver was applied, maybe we need
to apply it anyways?
I wouldn't call t186 unusable without it. The devkits work fine
without kernel pinmuxing as the bootloader configures everything to a
reasonable default. It's only if something non-standard (for example,
an audio codec) is plugged into one of the expansion headers that
runtime configuration could be needed. However, I do agree that it
would be worthwhile to move this forward for merging. Since it is
unlikely I will get the generation script to a usable state soon. If
Thierry or one of the other tegra maintainers agrees, I can start
addressing the review comments and send a new revision.
Alright then. Looks like we can't find anybody willing to work on those
scripts and it sounds like I'm one of very few that thinks there's still
some worth to them in this day.

Can you make a pass over the driver and make sure we have sufficient
spacing (last time I looked the various tables in this driver were all
very clustered together, so a few blank lines here and there would go a
long way to make things more readable), consistent indentation and such?

Thanks,
Thierry

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help