Thread (13 messages) 13 messages, 6 authors, 2025-07-21

Re: [PATCH 2/2] media: i2c: Add OmniVision OV6211 image sensor driver

From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: 2025-07-21 11:49:05
Also in: linux-media

Hi Mehdi, Vladimir,

On Mon, Jul 21, 2025 at 12:38:28PM +0200, Mehdi Djait wrote:
It has already been reviewed but yes still not in the media tree.
Too late for 6.17 but it will be in the media tree soon.
I'll send a PR including that once we have next rc1 in the media tree.
quoted
2. the only needed change to get support of the new helper is to replace
the single line of devm_clk_get_optional() with devm_v4l2_sensor_clk_get(),
no more than that,
Correct.
quoted
3. the internal complexity of devm_v4l2_sensor_clk_get() seems excessive
right over here, what's worse I can not test devm_v4l2_sensor_clk_get()
in this driver on any ACPI platform...
You don't need to test it on a ACPI-based platform to use the helper, if
it works for your DT-based platform that's enough.
Agreed.

-- 
Kind regards,

Sakari Ailus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help