Re: [PATCH v2 19/20] dt: bindings: fsl,vf610-pit: Add compatible for s32g2 and s32g3

On 31/07/2025 09:50, Krzysztof Kozlowski wrote:

On 31/07/2025 09:41, Daniel Lezcano wrote:

quoted

Hi Rob,

On 31/07/2025 01:36, Rob Herring wrote:

quoted

On Wed, Jul 30, 2025 at 10:27:21AM +0200, Daniel Lezcano wrote:

quoted

The Vybrid Family is a NXP (formerly Freescale) platform having a
Programmable Interrupt Timer (PIT). This timer is an IP found also on
the NXP Automotive platform S32G2 and S32G3.

Add the compatible for those platforms to describe the timer.

Signed-off-by: Daniel Lezcano <redacted>
---
   .../devicetree/bindings/timer/fsl,vf610-pit.yaml          | 8 ++++++--
   1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml
index bee2c35bd0e2..2aac63a58bfd 100644
--- a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml
+++ b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml

@@ -15,8 +15,12 @@ description:
   
   properties:
     compatible:
-    enum:
-      - fsl,vf610-pit
+    oneOf:
+      - const: fsl,vf610-pit
+      - const: nxp,s32g2-pit

These 2 can be a single enum. Otherwise,

Do you mean this ?

     enum:
       - fsl,vf610-pit
       - nxp,s32g2-pit

Yes.
And also please correct the subject prefix to match subsystem, git log
--oneline or:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Sure I'll replace it by:

dt-bindings: timer: Add the PIT for s32g2 and s32g3

Thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog