Thread (11 messages) 11 messages, 5 authors, 2025-08-12

Re: [PATCH v7 2/3] arm64: dts: qcom: sa8775p: remove aux clock from pcie phy

From: Johan Hovold <johan@kernel.org>
Date: 2025-07-30 09:53:05
Also in: linux-arm-msm, linux-pci, linux-phy, lkml

On Fri, Jul 25, 2025 at 06:22:30PM +0800, Ziyue Zhang wrote:
The gcc_aux_clk is used by the PCIe Root Complex (RC) and is not required
by the PHY. The correct clock for the PHY is gcc_phy_aux_clk, which this
patch uses to replace the incorrect reference.

The distinction between AUX_CLK and PHY_AUX_CLK is important: AUX_CLK is
typically used by the controller, while PHY_AUX_CLK is required by certain
PHYs—particularly Gen4 QMP PHYs—for internal operations such as clock
gating and power management. Some non-Gen4 Qualcomm PHYs also use
PHY_AUX_CLK, but they do not require AUX_CLK.

This change ensures proper clock configuration and avoids unnecessary
dependencies.

Signed-off-by: Ziyue Zhang <redacted>
With the fixes tag added (Konrad's comment should be picked up by the
maintainer/tooling, no need to resend for that):

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help