Thread (15 messages) 15 messages, 4 authors, 2025-07-08

Re: [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding

From: Rosen Penev <hidden>
Date: 2025-07-08 01:36:51
Also in: linux-arm-kernel, linux-mediatek, linux-mips, linux-wireless, lkml

On Mon, Jul 7, 2025 at 6:19 PM Daniel Golle [off-list ref] wrote:
On Sun, Jul 06, 2025 at 02:41:11PM -0700, Rosen Penev wrote:
quoted
MT7620A devices all contain a wifi device as part of the SOC. Add it
here to get it working.

Signed-off-by: Rosen Penev <redacted>
---
 arch/mips/boot/dts/ralink/mt7620a.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
The commit title

MIPS: dts: ralink: mt7628a: add wifi binding
That is embarrassing. I'm blaming my new Linux setup.
seems wrong as the commit (correctly) touches mt7620a.dtsi and not
mt7628a.dtsi (which would be wrong as the WiFi part of MT7628A is
already supported by the mt76 driver and part of the device tree).
Also the word 'binding' seems wrong in this context, you are adding
a node to the device tree, not to the device tree bindings.

I'd hence suggest to change the commit title to

MIPS: dts: ralink: mt7620a: add wifi
Will do
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help