-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Friday, July 4, 2025 3:51 PM
To: LI Qingwu <redacted>
Cc: lee@kernel.org; pavel@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
conor+dt@kernel.org; linux-leds@vger.kernel.org; devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org; GEO-CHHER-bsp-development
[off-list ref]
Subject: Re: [PATCH V4 1/2] dt-bindings: leds: pwm: add enable-gpios property

This email is not from Hexagon’s Office 365 instance. Please be careful while
clicking links, opening attachments, or replying to this email.


On Thu, Jul 03, 2025 at 11:36:10AM +0000, LI Qingwu wrote:

quoted

quoted

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Thursday, July 3, 2025 6:55 PM
To: LI Qingwu <redacted>; lee@kernel.org;
pavel@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
conor+dt@kernel.org; linux-leds@vger.kernel.org;
conor+devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org
Cc: GEO-CHHER-bsp-development
[off-list ref]
Subject: Re: [PATCH V4 1/2] dt-bindings: leds: pwm: add enable-gpios
property

This email is not from Hexagon’s Office 365 instance. Please be
careful while clicking links, opening attachments, or replying to this email.


On 03/07/2025 12:27, LI Qingwu wrote:

quoted

quoted

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Thursday, July 3, 2025 5:59 PM
To: LI Qingwu <redacted>;
lee@kernel.org; pavel@kernel.org; robh@kernel.org;
krzk+dt@kernel.org;
conor+dt@kernel.org; linux-leds@vger.kernel.org;
conor+devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org
Cc: GEO-CHHER-bsp-development
[off-list ref]
Subject: Re: [PATCH V4 1/2] dt-bindings: leds: pwm: add
enable-gpios property

This email is not from Hexagon’s Office 365 instance. Please be
careful while clicking links, opening attachments, or replying to this email.

Please drop this, it is not relevant in upstream discussions. Use
normal email client which will not produce useless header above.

quoted

quoted

On 03/07/2025 11:34, LI Qingwu wrote:

quoted

some pwm led driver chips like tps92380 require a separate
enable signal

Sentence starts with capital letter.

tps92380 does not have dedicated enable pin. It has VDDIO, which
serves also enable purpose, but it is a supply.

So this patch is unacceptable anyway?

If you make this patch for tps92380, I think it is not correct. You
have entire commit msg to explain the hardware and all unusual
things. Having VDDIO and EN pin is unusual, because you do not supply

power directly from GPIOs of a SoC.

quoted

quoted

All this should be explained.

Thank you for the feedback, what about rename to power-supply with

regulator support ?

quoted

Convert this patch to add regulator support instead of GPIO, using
"power-supply" property to control LED power, or drop this patch and give up

upstream, or what's the better from your point of view?

quoted

appreciate your guidance!

Does it solve your problem? It is surprising that once you say it is GPIO and once
as regulator. How is it in your board?

Regulator is looking as correct hardware description, so that patch would be
fine.

Thank you for your feedback and clarification.
On our hardware, the TPS92380's VDDIO/EN pin is connected to a GPIO,
which is used to enable or disable the device.
According to the datasheet, this pin is described as 
"enable input for the device as well as supply input (VDDIO) for digital 
pins". If describing this as a supply is the preferred and correct way for
upstream, I can implement as supply regulator controlled by GPIO, and to
model this behavior in device tree. 

or if you have a better suggestion for such cases.

Best regards,
Krzysztof