Re: [PATCH RFC 3/7] dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller
From: Frank Li <Frank.li@nxp.com>
Date: 2025-06-12 15:35:16
Also in:
linux-i3c, linux-renesas-soc
From: Frank Li <Frank.li@nxp.com>
Date: 2025-06-12 15:35:16
Also in:
linux-i3c, linux-renesas-soc
On Thu, Jun 12, 2025 at 04:51:42PM +0200, Tommaso Merciai wrote:
Hi Frank, Wolfram, Thanks both for your work. On 12/06/25 16:31, Wolfram Sang wrote:quoted
Hi Frank,quoted
quoted
+ clock-names: + oneOf: + - items: + - const: pclk + - const: tclk + - items: + - const: pclk + - const: pclkrw + - const: tclkSuggested clock name is, apb, trans, srfs. Needn't clk surfix and provide meanful name.? Why can't we have the name from the datasheets? It will be unnecessarily hard for users to verify the correctness of the clock assignments if they need an artifical mapping of these names. If they are the same as in the datasheet, the same task becomes very easy.Agreed. Since the name comes from the hw manual I think is better to leave it as is.
Previous Krzysztof give some feedback about clock-names, they don't perfer clk surfix, because clock-names already provide information, which is clock. Some hardware manual use it as signal name, for example, pclk which is apb bus clock. I am fine with align signal name. you can wait for DT team's feedback about this. Frank
Thanks & Regards, Tommaso