Re: [PATCH v2 7/8] auxdisplay: Add Titanmec TM16xx 7-segment display controllers driver

On 30/06/2025 09:27, Andy Shevchenko wrote:

On Mon, Jun 30, 2025 at 08:12:16AM +0200, Krzysztof Kozlowski wrote:

quoted

On 29/06/2025 15:18, Jean-François Lessard wrote:

...

quoted

quoted

+	display->leds =
+		devm_kcalloc(dev, display->num_leds, sizeof(*display->leds), GFP_KERNEL);

Wrong wrapping. Use kernel style, not clang style.

quoted

+	if (!display->leds)
+		return -ENOMEM;

Just wondering how .clang-format is official? Note some of the maintainers even

First time I hear above clang style is preferred. Where is it expected?
I assume clang-format is half-working and should not be used blindly,
but fixed to match actual kernel coding style.

prefer (ugly in some cases in my opinion) style because it's generated by the
clang-format.

Best regards,
Krzysztof