Re: [PATCH v2 4/7] irqchip: MIPS P800 variant of aclint-sswi

From
Inochi Amaoto <inochiama@gmail.com>
Date
2025-06-10 10:54:11
Also in
linux-riscv, lkml
Reply to
Vladimir Kondratiev, 2025-06-10
On Tue, Jun 10, 2025 at 10:46:23AM +0000, Vladimir Kondratiev wrote:
quoted
quoted
+#if defined(CONFIG_MIPS_P8700_ACLINT_SSWI)
+/* generic/MIPS variant */
quoted
I do not think there is a must to add these defines
OK, if there is no objections from others, I'll remove it. To clarify,
we're about removing both #if defined(CONFIG_MIPS_P8700_ACLINT_SSWI)
and #if defined(CONFIG_THEAD_C900_ACLINT_SSWI) ? And, I'll keep logic in Kconfig to select whole .c file if one of variants selected
I think all should be removed and it is OK to use old THEAD_C900_ACLINT_SSWI
as driver config. At least for now, I see no similar case about using defined.
Maybe the subsystem maintainer can give some more meaningful advice.

Regards,
Inochi
Thread (38 messages) 38 messages, 5 authors, last reply 2025-06-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help