Re: [PATCH v3 2/2] dt-bindings: leds: Add new as3668 support
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-06-05 06:21:44
Also in:
linux-leds, lkml
On Thu, Jun 05, 2025 at 12:58:38AM GMT, Lukas Timmermann wrote:
Document Osram as3668 LED driver devicetree bindings. Signed-off-by: Lukas Timmermann <linux@timmermann.space>
Please organize the patch documenting compatible (DT bindings) before their user. See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
quoted hunk ↗ jump to hunk
--- .../devicetree/bindings/leds/leds-as3668.yaml | 76 +++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-as3668.yamldiff --git a/Documentation/devicetree/bindings/leds/leds-as3668.yaml b/Documentation/devicetree/bindings/leds/leds-as3668.yaml new file mode 100644 index 000000000000..a9d698eb87d2 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-as3668.yaml
Filename matching compatible. ams,as3668.yaml
quoted hunk ↗ jump to hunk
@@ -0,0 +1,76 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/leds-as3668.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Osram 4-channel i2c LED driver.
Drop full stop
+ +maintainers: + - Lukas Timmermann [off-list ref] + +description: |
Drop |, Do not need '|' unless you need to preserve formatting.
+ This IC can drive up to four separate LEDs. + Having four channels suggests it could be used with a single RGBW LED. + +properties: + compatible: + const: ams,as3668 + + reg: + maxItems: 1 + description: + I2C slave address
Drop description, obvious.
+ + "#address-cells": + const: 1 + + "#size-cells": + const: 0
Missing gpio / pwm / audio input. I guess you omitted it because you do not know how to implement the audio input part? Bindings should be complete, so at least mention this in commit msg. Best regards, Krzysztof