Re: [PATCH v2 1/2] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-05-08 06:07:54
Also in:
linux-i3c, lkml
On 08/05/2025 06:57, Aman Kumar Pandey wrote:
Add bindings for the NXP P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841) multiport I3C hub family. These devices connect to a host via I3C/I2C/SMBus and allow communication with multiple downstream peripherals. Signed-off-by: Aman Kumar Pandey <redacted> Signed-off-by: Vikash Bansal <redacted> --- V1 -> V2: Cleaned up coding style and addressed review comments --- .../bindings/i3c/p3h2840-i3c-hub.yaml | 332 ++++++++++++++++++
Not much improved. I have doubts that you really looked at other bindings. Filename matching compatible.
quoted hunk ↗ jump to hunk
MAINTAINERS | 8 + 2 files changed, 340 insertions(+) create mode 100644 Documentation/devicetree/bindings/i3c/p3h2840-i3c-hub.yamldiff --git a/Documentation/devicetree/bindings/i3c/p3h2840-i3c-hub.yaml b/Documentation/devicetree/bindings/i3c/p3h2840-i3c-hub.yaml new file mode 100644 index 000000000000..f3b5aabf5fe0 --- /dev/null +++ b/Documentation/devicetree/bindings/i3c/p3h2840-i3c-hub.yaml@@ -0,0 +1,332 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright 2025 NXP + +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i3c/p3h2840-i3c-hub.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: P3H2X4X I3C HUB
nvidia? NXP? What is it?
+
+maintainers: + - Vikash Bansal [off-list ref] + - Aman Kumar Pandey [off-list ref] + +description: | + P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841) is a family of multiport I3C + hub devices that connect to:- + 1. A host CPU via I3C/I2C/SMBus bus on upstream side and connect to multiple + peripheral devices on the downstream side. + 2. Have two Controller Ports which can support either + I2C/SMBus or I3C buses and connect to a CPU, BMC or SOC. + 3. P3H2840/ P3H2841 are 8 port I3C hub with eight I3C/I2C Target Port. + 4. P3H2440/ P3H2441 are 4 port I3C hub with four I3C/I2C Target Port. + Target ports can be configured as I2C/SMBus, I3C or GPIO and connect to + peripherals. + +allOf: + - $ref: i3c.yaml# + +properties: + $nodename: + pattern: "^hub@[@.*]+,[0-9a-f]+$"
Drop
+ + Compatible:
Nothing improved. There is no single code with such syntax and I asked to use existing files as an example. You just ignored that comment and this is not acceptable.
+ const: nxp,p3h2x4x
No, you need specific compatibles.
+ + cp0-ldo-enable: + type: boolean + description: + Enables the on-die LDO for controller Port 0. + + cp1-ldo-enable: + type: boolean + description: + Enables the on-die LDO for controller Port 1. + + tp0145-ldo-enable: + type: boolean + description: + Enables the on-die LDO for target ports 0/1/4/5. + + tp2367-ldo-enable: + type: boolean + description: + Enables the on-die LDO for target ports 2/3/6/7. +
NAK for all above properties.
+ cp0-ldo-microvolt:
Do you see anywhere device properties named like that? Without prefix? I am not going to review the rest. You did not try hard enough to fulfill previous review request, you did not really test it. Start from scratch from latest accepted schema or from example-schema. Best regards, Krzysztof