Re: [PATCH] ARM: dts: bananapi: add support for PHY LEDs
From: Chen-Yu Tsai <hidden>
Date: 2025-05-07 15:45:44
Also in:
linux-arm-kernel, linux-sunxi, lkml
On Wed, May 7, 2025 at 4:56 AM Michael Klein [off-list ref] wrote:
The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY. Add the corresponding nodes to the device tree.
I see from old emails that this was supposed to be updated? And if you didn't, then his patch should be marked as a "RESEND", so tooling doesn't get confused and ignore it. I'll wait a couple days in case anyone else wants to take a look. ChenYu
quoted hunk ↗ jump to hunk
Signed-off-by: Michael Klein <redacted> --- .../boot/dts/allwinner/sun7i-a20-bananapi.dts | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+)diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts index 46ecf9db2324..d8b362c9661a 100644 --- a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts@@ -48,6 +48,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/leds/common.h> / { model = "LeMaker Banana Pi";@@ -169,6 +170,32 @@ &ir0 { &gmac_mdio { phy1: ethernet-phy@1 { reg = <1>; + + leds { + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_LAN; + linux,default-trigger = "netdev"; + }; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_AMBER>; + function = LED_FUNCTION_LAN; + linux,default-trigger = "netdev"; + }; + + led@2 { + reg = <2>; + color = <LED_COLOR_ID_BLUE>; + function = LED_FUNCTION_LAN; + linux,default-trigger = "netdev"; + }; + }; }; }; --2.39.5