On Tue May 6, 2025 at 7:14 AM CEST, Dmitry Torokhov wrote:

On Fri, May 02, 2025 at 01:46:35PM +0300, Andy Shevchenko wrote:

quoted

On Mon, Apr 28, 2025 at 01:57:27PM +0200, Mathieu Dubois-Briand wrote:

quoted

+	error = matrix_keypad_build_keymap(&keymap_data, NULL,
+					   max7360_keypad->rows, max7360_keypad->cols,
+					   max7360_keypad->keycodes, max7360_keypad->input);
+
+	return error;

	return matrix_...(...);

Because that function has multiple failure points please

	if (error)
		return error; // or return dev_err_probe()

	return 0;

Thanks.

Noted, I will change this.

Thanks for your review.
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com