Thread (55 messages) 55 messages, 10 authors, 2025-03-13

Re: [PATCH hyperv-next v5 08/11] Drivers: hv: vmbus: Get the IRQ number from DeviceTree

From: Roman Kisel <hidden>
Date: 2025-03-13 18:46:59
Also in: kvmarm, linux-acpi, linux-arch, linux-arm-kernel, linux-hyperv, linux-pci, lkml


On 3/13/2025 11:44 AM, Rob Herring wrote:
On Fri, Mar 7, 2025 at 4:03 PM Roman Kisel [off-list ref] wrote:
[...]
quoted
+       irq = platform_get_irq(pdev, 0);
+       if (irq == 0) {
+               pr_err("VMBus interrupt mapping failure\n");
+               return -EINVAL;
+       }
+       if (irq < 0) {
+               pr_err("VMBus interrupt data can't be read from DeviceTree, error %d\n", irq);
+               return irq;
+       }
I don't think why you couldn't get the interrupt is important. Just
check for (irq <= 0) and be done with it. I'm not even sure if
returning 0 is possible now. There's a long history to that and
NO_IRQ.
That will certainly make the code look much better!
Thank you very much for the idea!
Rob
-- 
Thank you,
Roman
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help