RE: [PATCH 3/7] dt-bindings: thermal: r9a09g047-tsu: Document the TSU unit

From
John Madieu <john.madieu.xa@bp.renesas.com>
Date
2025-02-26 15:40:42
Also in
linux-clk, linux-renesas-soc, lkml
Reply to
Rob Herring, 2025-02-20
Hi Rob,

Thanks for your review.
-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Thursday, February 20, 2025 8:17 PM
Subject: Re: [PATCH 3/7] dt-bindings: thermal: r9a09g047-tsu: Document the
TSU unit

On Thu, Feb 20, 2025 at 04:26:08PM +0100, John Madieu wrote:
quoted
The Renesas RZ/G3E SoC includes a Thermal Sensor Unit (TSU) block
designed to measure the junction temperature. The device provides
real-time temperature measurements for thermal management, utilizing a
single dedicated channel (channel 1) for temperature sensing.

Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
---
 .../thermal/renesas,r9a09g047-tsu.yaml        | 123 ++++++++++++++++++
 1 file changed, 123 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml

diff --git
a/Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml
b/Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml
new file mode 100644
index 000000000000..dbd3860a31d0
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.
+++ yaml
@@ -0,0 +1,123 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
+---
+title: Renesas RZ/G3E Temperature Sensor Unit (TSU)
+
+maintainers:
+  - John Madieu <john.madieu.xa@bp.renesas.com>
+
+description: |
Don't need '|' if there is no formatting to preserve.
Got it, Thanks! Will remove it in v2 since there is no
special formatting requirement here.
quoted
+  The Temperature Sensor Unit (TSU) is an integrated thermal sensor
+ that monitors
Wrap lines at <80 char.
Will do in v2.
quoted
+  the chip temperature on the Renesas RZ/G3E SoC. The TSU provides
+ real-time  temperature measurements for thermal management.
+
+properties:
+  compatible:
+    const: renesas,r9a09g047-tsu
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
+  interrupts:
+    description: |
+      Interrupt specifiers for the TSU:
+      - S12TSUADI1: Conversion complete interrupt signal (pulse)
+      - S12TSUADCMPI1: Comparison result interrupt signal (level)
+
+  interrupt-names:
+    items:
+      - const: S12TSUADI1
+      - const: S12TSUADCMPI1
Odd names for the interrupts... 'S12TSUAD' is the same for both, so that
part is redundant from my perspective. I guess if these strings are
meaningful for anyone familiar with this h/w, then it's fine.
These names come from HW manual. I can change them into "conv"
(for conversion complete irq)  and "cmp" (for comparison
complete irq). What do you think ?
quoted
+
+  "#thermal-sensor-cells":
+    const: 0
+
+  renesas,tsu-calibration-sys:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: |
+      Phandle to the system controller (sys) that contains the TSU
+      calibration values used for temperature calculations.
+
       sensor_crit: sensor-crit {
quoted
+                    temperature = <120000>;
+                    hysteresis = <1000>;
+                    type = "critical";
+                };
+            };
+        };
+    };
Cheers,
John!
quoted
--
2.25.1
Thread (14 messages) 14 messages, 3 authors, last reply 2025-02-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help