Re: [PATCH v2 2/3] mfd: sec: add support for S2MPU05 PMIC

On 24/02/2025 18:37, Kaustabh Chakraborty wrote:

On 2025-02-23 16:10, Krzysztof Kozlowski wrote:

quoted

Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also 'scripts/checkpatch.pl --strict' and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.

Missing bindings.

Bindings have been applied in v1.

Heh, I see email from Lee now but mainline does not have them, next from
19th Feb neither.

BTW, what happened with all the review tags? Nothing in cover letter nor
changelog explains dropping reviews.

quoted

BTW, don't combine independent patches from different subsystems into
one patchset. It's not helping anyone especially without explaining
dependencies/merging in the cover letter or here in changelog.

Alright I'm a bit lost here. The binding patch (the one you enquired
for above) referenced the regulator bindings, whereas the regulator
driver is including the S2MU005 PMIC header which defines the
register addresses, etc.

You have entire cover letter to explain dependencies and merging... If
you target specific subsystem - write.

So it seems like patches from both subsystems are inter-dependent
on each other, and hence both are put together in a single series.

What should I do then? Should I explicitly mention this in the cover
letter? Or split into two? Or...?

Best regards,
Krzysztof