Thread (56 messages) 56 messages, 6 authors, 2025-02-22

Re: [PATCH v2 13/29] ASoC: tas2770: Export 'die_temp' to sysfs

From: Alyssa Rosenzweig <hidden>
Date: 2025-02-18 16:09:23
Also in: asahi, linux-hwmon, linux-sound, lkml

Le Tue, Feb 18, 2025 at 03:22:19PM +0000, Mark Brown a écrit :
On Tue, Feb 18, 2025 at 06:35:47PM +1000, James Calligeros wrote:
quoted
From: Martin Povišer <povik+lin@cutebit.org>

Export a file for the readout of die temperature measurements.
As per the datasheet, the temperature can be calculated by
dividing the register value by 16 and then subtracting 93.
Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.
Which review comment...? The only thing I could find was about hwmon
exporting, which James added a patch for in v2 ("ASoC: tas2770: expose
die temp to hwmon"). Maybe I missed an email?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help