Re: [PATCH v6 0/4] Add support for errors recovery in the TI SN65DSI83 bridge driver

From
Alexander Stein <hidden>
Date
2025-02-14 07:34:14
Also in
dri-devel, lkml
Reply to
Herve Codina, 2025-02-10
Hi,

Am Montag, 10. Februar 2025, 14:26:15 CET schrieb Herve Codina:
Hi,

Usually the TI SN65DSI83 recovers from error by itself but during ESD
tests, we have some cases where the TI SN65DSI83 didn't recover.

In order to handle those cases, this series adds support for a recovery
mechanism.

Compare to the previous iteration, this v6 series fixes a NULL
pointer dereference.

Best regards,
Hervé Codina
FWIW
Tested-by: Alexander Stein <redacted> #tqma8mqml-mba8mx
Changes v5 -> v6
  v5: https://lore.kernel.org/lkml/20250203161607.223731-1-herve.codina@bootlin.com/ (local)

  - Patch 1:
    No change

  - Patch 2
    Add 'Reviewed-by: Dmitry Baryshkov [off-list ref]'
    Add 'Reviewed-by: Maxime Ripard [off-list ref]'

  - Patch 3
    Add 'Acked-by: Dmitry Baryshkov [off-list ref]'
    Add 'Reviewed-by: Maxime Ripard [off-list ref]'

  - Patch 4
    Add 'Reviewed-by: Maxime Ripard [off-list ref]'
    Fix a NULL pointer dereference reported by Alexander Stein in v5.
    Mode the dev_warn() signaling the pipe reset closer to the pipe
    reset operation itfelf.

Changes v4 -> v5
  v4: https://lore.kernel.org/lkml/20250203145824.155869-1-herve.codina@bootlin.com/ (local)

  Exact same changes as the v4. The v4 series doesn't apply on top of
  v6.14-rc1 and should be simply ignore.
  This v5 series is the v4 fixed to apply on top of v6.14-rc1.

Changes v3 -> v4
  v3: https://lore.kernel.org/lkml/20250108101907.410456-1-herve.codina@bootlin.com/ (local)

  - Patch 1:
    No changes

  - Patch 2 and 3 (patch 2 in v3):
    Rename the helper to drm_atomic_helper_reset_crtc()
    Split the patch available in v3 in two patches.

  - Patch 4 (patch 3 in v3):
    Take into account commit d2b8c6d549570 ("drm/bridge: ti-sn65dsi83:
    Add ti,lvds-vod-swing optional properties"), available in v6.14-rc1.
    Disable irq when a fault is detected and re-enable it after the pipe
    reset.
    Remove state duplication and use bridge.encoder->crtc directly

Changes v2 -> v3
  v2: https://lore.kernel.org/lkml/20241217143216.658461-1-herve.codina@bootlin.com/ (local)

  - Patch 1:
    No changes

  - Patch 2 (new in v3)
    Move reset_pipe() from VC4 HDMI driver to a new atomic helper

  - Patch 3
    Use the new drm_atomic_helper_reset_pipe()

  Patch removed in v3
    - Patch 2 in v2
      No more needed

Changes v1 -> v2
  v1: https://lore.kernel.org/lkml/20241024095539.1637280-1-herve.codina@bootlin.com/ (local)

  - Patch 1:
    Add 'Reviewed-by: Laurent Pinchart [off-list ref]'
    Add 'Acked-by: Conor Dooley [off-list ref]'

  - Patch 2 (new patch in v2)
    Introduce drm_atomic_helper_disable_connector()

  - Patch 3 (patch 2 in v1)
    Reset the output path instead of the full pipeline.
    Update and add more information related to the bridge in commit log.

Herve Codina (4):
  dt-bindings: display: bridge: sn65dsi83: Add interrupt
  drm/atomic-helper: Introduce drm_atomic_helper_reset_crtc()
  drm/vc4: hdmi: Use drm_atomic_helper_reset_crtc()
  drm: bridge: ti-sn65dsi83: Add error recovery mechanism

 .../bindings/display/bridge/ti,sn65dsi83.yaml |   3 +
 drivers/gpu/drm/bridge/ti-sn65dsi83.c         | 142 ++++++++++++++++++
 drivers/gpu/drm/drm_atomic_helper.c           |  41 +++++
 drivers/gpu/drm/vc4/vc4_hdmi.c                |  30 +---
 include/drm/drm_atomic_helper.h               |   2 +
 5 files changed, 189 insertions(+), 29 deletions(-)

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Thread (8 messages) 8 messages, 3 authors, last reply 2025-02-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help