Re: [PATCH v4 3/6] dt-bindings: net: dwmac: add compatible for Agilex5
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-02-10 10:24:02
Also in:
lkml, netdev
On Wed, Feb 05, 2025 at 04:32:24PM +0100, Steffen Trumtrar wrote:
quoted hunk ↗ jump to hunk
The Agilex5 SoCs have three Synopsys DWXGMAC-compatible ethernet IP-cores. Add a SoC-specific front compatible to the binding. Signed-off-by: Steffen Trumtrar <redacted> --- Documentation/devicetree/bindings/net/socfpga-dwmac.yaml | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.yaml b/Documentation/devicetree/bindings/net/socfpga-dwmac.yaml index 2568dd90f4555485f18912b5352f191824bb918c..31c163bf1b59e14216d1fb4b4b9aaa747e1b19e2 100644 --- a/Documentation/devicetree/bindings/net/socfpga-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.yaml@@ -21,6 +21,7 @@ select: enum: - altr,socfpga-stmmac # For Cyclone5/Arria5 SoCs - altr,socfpga-stmmac-a10-s10 # For Arria10/Agilex/Stratix10 SoCs + - altr,socfpga-stmmac-agilex5 # For Agilex5 SoCs required: - compatible@@ -45,6 +46,12 @@ properties: - altr,socfpga-stmmac-a10-s10 - const: snps,dwmac-3.74a - const: snps,dwmac + - items: + - enum: + - altr,socfpga-stmmac-agilex5 + - const: altr,socfpga-stmmac-a10-s10 + - const: snps,dwxgmac-2.10
No, don't grow this pattern. a10-s10 *MUST* be one specific device, so it cannot be compatible with 3.72, 3.74 and 2.10 in the same time. I understand that old DTS was here wrong, that ship has failed, but don't grow it. All your compatibles must be specific, which means they must represent one logical choice. You claim now that a10-s10 covers now three entirely different devices. Best regards, Krzysztof